Make mutating operations on wrapped maps work#8
Open
bdonlan wants to merge 1 commit intorschmitt:masterfrom
Open
Make mutating operations on wrapped maps work#8bdonlan wants to merge 1 commit intorschmitt:masterfrom
bdonlan wants to merge 1 commit intorschmitt:masterfrom
Conversation
Currently, wrapped maps use the passed-in Map as-is. This produces intuitive results when the Map is mutated, but as soon as you try to modify the DynamicObject, you get cryptic errors due to attempts to use this Map as an IPersistentMap or IObj (in the case of metadata operations). This change introduces a wrapper which proxies non-mutating calls through to the underlying map directly, but which creates a copy of the map (as a PersistentHashMap) if mutating operations are performed. I considered simply having wrap() copy the map directly, but I felt that the name 'wrap' would be seen to imply that mutations on the underlying map would be reflected in the wrapped DynamicObject, so I chose this route instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, wrapped maps use the passed-in Map as-is. This produces intuitive
results when the Map is mutated, but as soon as you try to modify the
DynamicObject, you get cryptic errors due to attempts to use this Map as an
IPersistentMap or IObj (in the case of metadata operations).
This change introduces a wrapper which proxies non-mutating calls through to
the underlying map directly, but which creates a copy of the map (as a
PersistentHashMap) if mutating operations are performed.
I considered simply having wrap() copy the map directly, but I felt that the
name 'wrap' would be seen to imply that mutations on the underlying map would
be reflected in the wrapped DynamicObject, so I chose this route instead.