Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 24h change floor #193

Closed
wants to merge 3 commits into from
Closed

add 24h change floor #193

wants to merge 3 commits into from

Conversation

rickstaa
Copy link
Contributor

@rickstaa rickstaa commented Jan 11, 2023 •
edited
Loading

This PR adds the collection_stats and collection_stats_append parameters which can be used to show extra stats like the number of listings in the floor ticker activity field.

@rickstaa rickstaa requested a review from rssnyder as a code owner January 11, 2023 11:57
@rickstaa rickstaa force-pushed the add_24h_change_floor branch 2 times, most recently from 7d813e1 to f78f20d Compare January 11, 2023 12:06
@rickstaa
Copy link
Contributor Author

@rssnyder Here is another PR you might find interesting. I use it in my discord servers.

@rickstaa

This comment was marked as outdated.

Sign in to view
@rickstaa rickstaa force-pushed the add_24h_change_floor branch from f78f20d to a405bd3 Compare January 12, 2023 10:12
@rickstaa
feat: add extra collection stats activity to floor ticker
df9fb95 
This commit adds the `collection_stats` and `collection_stats_append` parameters
which can be used to show extra stats like the number of listings in the floor
ticker activity field.
@rickstaa rickstaa force-pushed the add_24h_change_floor branch from a405bd3 to df9fb95 Compare January 12, 2023 10:15
@rickstaa
Copy link
Contributor Author

Warning
@rssnyder Don't merge I just noticed that Magic Eden does not yet provide the 24-hour floor price. See review comment.

@rssnyder Now we are good to go! I fixed the stats.

@stale
Copy link

stale bot commented Feb 11, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 11, 2023
@rickstaa
Copy link
Contributor Author

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@bot I don't think this issue is stale 😅. It was created a little more than a month ago.

@stale stale bot removed the wontfix This will not be worked on label Feb 13, 2023
@rssnyder
Copy link
Owner

@rickstaa resolve conflicts and i will review

@rickstaa rickstaa force-pushed the add_24h_change_floor branch from 1235dfa to deb35ca Compare February 14, 2023 10:45
@rickstaa
Copy link
Contributor Author

@rssnyder Done 👍🏻.

@rickstaa
Copy link
Contributor Author

@rssnyder I was wondering if you want me to change things to this pull request. I have used this for some months in my discord groups, and it works. No hurries, though; I can run it from my fork. I just wanted to let you know that if you need me to change things, you can ping me 🤝. Thanks again for the fantastic tool 🙏🏻.

@stale
Copy link

stale bot commented Apr 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 17, 2023
@rickstaa
Copy link
Contributor Author

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Not stale 🤖.

@stale stale bot removed the wontfix This will not be worked on label Apr 17, 2023
@rickstaa rickstaa mentioned this pull request Apr 24, 2023
Closed
@stale
Copy link

stale bot commented May 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 17, 2023
@rickstaa
Copy link
Contributor Author

rickstaa commented May 19, 2023 •
edited
Loading

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Dear @Stale bot, this pull request still is not stale 🤖.

@stale stale bot removed the wontfix This will not be worked on label May 19, 2023
@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 18, 2023
@rickstaa
Copy link
Contributor Author

rickstaa commented Oct 12, 2023 •
edited
Loading

@rssnyder Ah, I see you already merged the master into my branch. Thanks! I was on holiday 😃. Please let me know if you need any changes 👍🏻.

@stale Stale
Copy link

stale bot commented Nov 11, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 11, 2023
@rickstaa
Copy link
Contributor Author

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Again not stale @Stale.

@stale stale bot removed the wontfix This will not be worked on label Nov 11, 2023
@stale Stale
Copy link

stale bot commented Dec 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 12, 2023
@rickstaa
Copy link
Contributor Author

Stil not stale 🤖.

@stale stale bot removed the wontfix This will not be worked on label Dec 12, 2023
@stale Stale
Copy link

stale bot commented Jan 11, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 11, 2024
@rickstaa
Copy link
Contributor Author

Again not stale @Stale bot 😅.

@stale stale bot removed the wontfix This will not be worked on label Jan 11, 2024
@stale Stale
Copy link

stale bot commented Feb 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 10, 2024
@rickstaa
Copy link
Contributor Author

Not stale.

@stale stale bot removed the wontfix This will not be worked on label Feb 11, 2024
@stale Stale
Copy link

stale bot commented Mar 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 12, 2024
@rickstaa
Copy link
Contributor Author

Not stale.

@stale stale bot removed the wontfix This will not be worked on label Mar 12, 2024
@stale Stale
Copy link

stale bot commented Apr 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 12, 2024
@rickstaa
Copy link
Contributor Author

Not stale.

@stale stale bot removed the wontfix This will not be worked on label Apr 13, 2024
@stale Stale
Copy link

stale bot commented May 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 13, 2024
@stale stale bot closed this May 20, 2024
@rickstaa
Copy link
Contributor Author

Not stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rssnyder rssnyder Awaiting requested review from rssnyder rssnyder is a code owner

Assignees

@rssnyder rssnyder

Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickstaa @rssnyder