Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for R binaries and packages #23

Closed
wants to merge 6 commits into from
Closed

Tests for R binaries and packages #23

wants to merge 6 commits into from

Conversation

glin
Copy link
Contributor

@glin glin commented Aug 8, 2019

These are tests to help verify that the R binaries are configured/compiled properly, and that the R packages work.

Specifically, this installs the R deb/rpm in a base OS container, runs some R tests, and uninstalls the deb/rpm. The R tests were copied from https://github.com/rstudio/r-docker, but I only pulled in the tests relevant to r-builds (e.g. BLAS is configured properly, no missing runtime libraries, help pages work).

To test locally, first build the R packages:

# Build R 3.5.3 on each OS
R_VERSION=3.5.3 make docker-build-r

# Or build on a specific OS
cd builder && R_VERSION=3.5.3 docker-compose up ubuntu-1604

# Note: this outputs packages to builder/integration/tmp. To rebuild,
# clear out any existing packages in that directory

And then run the tests:

# Test R 3.5.3 on each OS
R_VERSION=3.5.3 make docker-test-r

# Or test on a specific OS
cd test && R_VERSION=3.5.3 docker-compose up ubuntu-1604

@glin glin mentioned this pull request Aug 8, 2019
@@ -8,7 +8,7 @@ if [ ! -f ${PKG_FILE} ]; then
exit 0
fi

zypper --non-interactive install ${PKG_FILE}
zypper --non-interactive --no-gpg-checks install ${PKG_FILE}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this brings up an interesting question -- should we start signing our installers? Jenkins is already configured with the secrets we need for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that'd be great. We still have this issue open: #7

@glin
Copy link
Contributor Author

glin commented Aug 11, 2022

Closing - I've redone this and will open a new PR

@glin glin closed this Aug 11, 2022
@glin glin deleted the glin/test branch August 11, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants