Vectorise str_replace_all() #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the development version of stringr, I'm exploring vectorising the function form of `str_replace_all()` (https://github.com/tidyverse/stringr/pull/4620) because it offers considerable performance improvements. This patch quickly hacks rmarkdown to work with this change. It would probably be worthwhile to vectorise the two users of `process_html_res()` as that is likely to give a small, but meaningful, performance boost when there are many matches.
cderv
approved these changes
Oct 4, 2022
|
Thank you. Last release of rmarkdown was in August so we could probably release a new version very soon if you need that for stringr new release. @yihui would that work ? When do you schedule the new stringr release ? |
yihui
approved these changes
Oct 4, 2022
[ci skip]
|
That would be great, but there's no need to rush on my behalf as this is I'm unlikely to start the stringr release process for at least two weeks. |
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Nov 7, 2022
Merge remote-tracking branch 'rstudio/main' into jg-tree-fix # By Yihui Xie (5) and others # Via Yihui Xie * rstudio/main: refactor the code a little bit allow custom output format to define its own Markdown converting function, so that we could use other tools (not necessarily Pandoc) rewrap lines Add render() output_file argument repetition (rstudio#2422) start the next version CRAN release v2.17 Vectorise str_replace_all() (rstudio#2416) Correctly load glyphicons in dropdown tabset add vscode lua config to gitignore Search also in `index.rmd` for `site:` key in YAML header (rstudio#2413) # Conflicts: # NEWS.md
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Nov 7, 2022
* jg-devel: refactor the code a little bit allow custom output format to define its own Markdown converting function, so that we could use other tools (not necessarily Pandoc) rewrap lines Add render() output_file argument repetition (rstudio#2422) start the next version CRAN release v2.17 Vectorise str_replace_all() (rstudio#2416) Correctly load glyphicons in dropdown tabset add vscode lua config to gitignore Search also in `index.rmd` for `site:` key in YAML header (rstudio#2413)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the development version of stringr, I'm exploring vectorising the function form of
str_replace_all()(tidyverse/stringr#462) because it offers considerable performance improvements. This patch quickly hacks rmarkdown to work with this change. It would probably be worthwhile to vectorise the two users ofprocess_html_res()as that is likely to give a small, but meaningful, performance boost when there are many matches.This patch will work with both CRAN and dev stringr.