Voila mode #340
Merged
Voila mode #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 89146b1.
bcwu
approved these changes
Feb 10, 2023
mmarchetti
force-pushed
the
mm-voila
branch
4 times, most recently
from
766888c
to
71c45e4
Compare
|
This should not be merged until Voila support lands in an |
isabelizimm
reviewed
Feb 28, 2023
| @@ -1033,6 +1033,11 @@ define([ | |||
| $subdirsBox.prop('checked', false); | |||
| } | |||
| $subdirsBox.parent().toggleClass('rsc-text-light', !canIncludeSubdirs); | |||
|
|
|||
| // Disable hide code cells options in Voila mode, since Voila always hides them. | |||
There was a problem hiding this comment.
The code cell boxes are already greyed out when Voila mode is selected. Is there more that should be done to complete #348 ?
There was a problem hiding this comment.
We should review the docs on hiding code cells to see if any updates are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a 3rd mode button to publish in Voila mode.
Connected to #https://github.com/rstudio/connect/issues/22745