Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect: use the public /v1/tasks/{id} endpoint #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

connect: use the public /v1/tasks/{id} endpoint #39

wants to merge 1 commit into from
+47 −40

Conversation

aronatkins
Copy link
Contributor

  • deployApp() continues to return a v0 task
  • getTask() accepts first and wait arguments and returns a v1 task
  • ClientTaskPoller uses long-polling rather than sleeping; returns a result with "output" rather than "status"

fixes #38

@aronatkins
connect: use the public /v1/tasks/{id} endpoint
783a4a8 
* deployApp() continues to return a v0 task
* getTask() accepts first and wait arguments and returns a v1 task
* ClientTaskPoller uses long-polling rather than sleeping; returns a result with "output" rather than "status"

fixes #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toph-allen toph-allen toph-allen approved these changes

@meatballhat meatballhat Awaiting requested review from meatballhat

@tdstein tdstein Awaiting requested review from tdstein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use /v1/tasks/{id} for task polling
2 participants
@aronatkins @toph-allen