Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect: use the public /v1/tasks/{id} endpoint #39

Merged
merged 2 commits into from
Oct 7, 2024
Merged

connect: use the public /v1/tasks/{id} endpoint #39

merged 2 commits into from
Oct 7, 2024
+47 −40

Conversation

aronatkins
Copy link
Contributor

  • deployApp() continues to return a v0 task
  • getTask() accepts first and wait arguments and returns a v1 task
  • ClientTaskPoller uses long-polling rather than sleeping; returns a result with "output" rather than "status"

fixes #38

@aronatkins
connect: use the public /v1/tasks/{id} endpoint
783a4a8 
* deployApp() continues to return a v0 task
* getTask() accepts first and wait arguments and returns a v1 task
* ClientTaskPoller uses long-polling rather than sleeping; returns a result with "output" rather than "status"

fixes #38
@tdstein tdstein merged commit f7da7e3 into main Oct 7, 2024
2 checks passed
@tdstein tdstein deleted the aron-v1-tasks branch October 7, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toph-allen toph-allen toph-allen approved these changes

@tdstein tdstein tdstein approved these changes

@meatballhat meatballhat Awaiting requested review from meatballhat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use /v1/tasks/{id} for task polling
3 participants
@aronatkins @toph-allen @tdstein