Jammy and some package updates for it #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samperman
reviewed
Sep 25, 2023
There was a problem hiding this comment.
why do we need this? is the comment on the top of the file accurate? (this is for certificate requests?)
There was a problem hiding this comment.
It's in here just because I think its simplest think about and maintain these dockerfiles if they're as close to the images shinyapps.io runs on as possible, and they have this file. They in turn have this file because, according to git and support ticket history, some folks like to connect to very old database server instances on old infrastructure that doesn't support modern TLS versions.
samperman
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #349
Passing build is here https://github.com/rstudio/shinyapps-package-dependencies/actions/runs/6301214401 or wait for the current one to finish.