Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
cpsievert authored May 17, 2024
1 parent d4b3228 commit 05eda24
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 20 deletions.
4 changes: 0 additions & 4 deletions .github/internal/install-shinyverse/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ inputs:
description: packagemanager url to be used for CRAN installations
default: "https://packagemanager.posit.co/cran/latest"
required: false
shinyverse-cran-url:
description: CRAN url to be used for shinyverse installations via r-universe
default: "https://posit-dev-shinycoreci.r-universe.dev"
required: false
cran-url:
description: CRAN url to be used for CRAN installations
default: "https://cran.rstudio.com"
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/apps-test-os.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ on:
description: packagemanager url to be used for CRAN installations
default: "https://packagemanager.posit.co/cran/latest"
required: false
shinyverse-cran-url:
type: string
description: CRAN url to be used for shinyverse installations via r-universe
default: "https://posit-dev-shinycoreci.r-universe.dev"
required: false
# rtools-35:
# type: boolean
# default: true
Expand Down Expand Up @@ -141,7 +136,6 @@ jobs:
pandoc-version: ${{ inputs.pandoc-version }}
extra-packages: ${{ inputs.extra-packages }}
packagemanager-cran-url: ${{ inputs.packagemanager-cran-url }}
shinyverse-cran-url: ${{ inputs.shinyverse-cran-url }}

# Install packages as necessary!
- name: Run tests
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ These GitHub packages will be installed to make sure the latest package developm

#### R-Universe

`{shinycoreci}` testing leverages rOpenScie [`r-universe`](https://r-universe.dev/search/), specifically the [`posit-dev-shinycoreci`](https://posit-dev-shinycoreci.r-universe.dev/builds) universe. This universe is used to install the latest development versions of the Shiny related packages (updated hourly) used in the testing apps without the need for a GitHub token. This last detail is important, as it allows GitHub Actions to install packages freely without the worry of being rate limited. This gives us the ability to attempt to install each app’s dependencies independently, leading to higher test coverage as a single dependencies does not block the entire test execution.
`{shinycoreci}` testing leverages rOpenSci [`r-universe`](https://r-universe.dev/search/), specifically the [`posit-dev-shinycoreci`](https://posit-dev-shinycoreci.r-universe.dev/builds) universe. This universe is used to install the latest development versions of the Shiny related packages (updated hourly) used in the testing apps without the need for a GitHub token. This last detail is important, as it allows GitHub Actions to install packages freely without the worry of being rate limited. This gives us the ability to attempt to install each app’s dependencies independently, leading to higher test coverage as a single dependencies does not block the entire test execution.

## Running manual tests

Expand Down
9 changes: 0 additions & 9 deletions inst/apps/000-pkg-versions/app.R
Original file line number Diff line number Diff line change
Expand Up @@ -106,15 +106,6 @@ server <- function(input, output, session) {
})

output$all_pkg_info <- renderPrint({
# pkg_info <- sessioninfo::package_info("installed", include_base = FALSE)

# pkg_info %>%
# dplyr::filter(package %in% pkgs, ) %>%
# dplyr::filter
# dplyr::select(package, version, loaded, attached, libPath)

# sub_pkg_info <- pkg_info[pkg_info$package %in% pkgs, ]

dt %>%
print(n = Inf, width = 1000)
})
Expand Down

0 comments on commit 05eda24

Please sign in to comment.