Set the option in the app itself

rstudio · Mar 20, 2024 · 71a96da · 71a96da
1 parent f00fa71
commit 71a96da
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/inst/apps/126-async-ticks/app.R b/inst/apps/126-async-ticks/app.R
@@ -3,6 +3,9 @@ library(promises)
 library(future)
 plan(multisession)
 
+opts <- options(shiny.legacy.datatable = TRUE)
+onStop(function() options(opts))
+
 testForMissingRenderFunctions <- function() {
   # If we add any render functions, they should be added to this test app. This test
   # will make it obvious if we forget.

diff --git a/inst/apps/126-async-ticks/tests/testthat/_snaps/mac-4.3/mytest/002.new.png b/inst/apps/126-async-ticks/tests/testthat/_snaps/mac-4.3/mytest/002.new.png
diff --git a/inst/apps/126-async-ticks/tests/testthat/test-mytest.R b/inst/apps/126-async-ticks/tests/testthat/test-mytest.R
@@ -1,13 +1,7 @@
 library(shinytest2)
 
 test_that("Migrated shinytest test: mytest.R", {
-  app <- AppDriver$new(
-    variant = shinytest2::platform_variant(),
-    # Use legacy datatable implementation just for the 
-    # info$datatable$colnames test below. We could, of course, 
-    # update that test, but it's also good to test the legacy.
-    options = list(shiny.legacy.datatable = TRUE)
-  )
+  app <- AppDriver$new(variant = shinytest2::platform_variant())
 
   app$expect_values()
   app$expect_screenshot()