chore: improve loading of shinytest2 js

rstudio · Nov 15, 2023 · 75b89ac · 75b89ac
1 parent fbf5a0c
commit 75b89ac
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 5 deletions.
diff --git a/inst/apps/317-bslib-preset-shiny-dashboard/app.R b/inst/apps/317-bslib-preset-shiny-dashboard/app.R
@@ -52,9 +52,6 @@ toggle_class_buttons <- HTML('
     <label class="form-check-label" for="shadow_lg_toggle">Large Shadow Class</label>
 </div>
 </fieldset>
-<script>document.querySelectorAll(".body-class-toggle").forEach((el) => {
-  el.checked = document.body.classList.contains(el.dataset.class)
-})</script>
 ')
 
 

diff --git a/...iny-dashboard/317-bslib-preset-shiny-dashboard-fillable-nested_05_mode_dark.png b/...iny-dashboard/317-bslib-preset-shiny-dashboard-fillable-nested_05_mode_dark.png
diff --git a/...-shiny-dashboard/317-bslib-preset-shiny-dashboard-flow-sidebar_05_mode_dark.png b/...-shiny-dashboard/317-bslib-preset-shiny-dashboard-flow-sidebar_05_mode_dark.png
diff --git a/...s/317-bslib-preset-shiny-dashboard/tests/testthat/test-317-bslib-preset-shiny-dashboard.R b/...s/317-bslib-preset-shiny-dashboard/tests/testthat/test-317-bslib-preset-shiny-dashboard.R
@@ -53,11 +53,11 @@ nav_to_variant <- function(app, ...) {
   url <- sprintf("%s?%s", app$get_url(), params)
   chrm <- app$get_chromote_session()
 
-  p <- chrm$Page$navigate(url, wait_ = FALSE)$
-    then(function(...) chrm$Page$loadEventFired(wait_ = FALSE))$
+  p <- chrm$Page$loadEventFired(wait_ = FALSE)$
     then(function(...) chrm$Runtime$evaluate(shinytest2_js, wait_ = FALSE))$
     then(function(...) app$wait_for_idle())
 
+  chrm$Page$navigate(url, wait_ = FALSE)
   chrm$wait_for(p)
   invisible(app)
 }