test(310): Use latest chromote

rstudio · Oct 27, 2023 · d906e10 · d906e10
1 parent b4f702c
commit d906e10
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/inst/apps/310-bslib-sidebar-dynamic/app.R b/inst/apps/310-bslib-sidebar-dynamic/app.R
@@ -83,8 +83,6 @@ nested_sidebar <- function(idx = 0L) {
 ui <- page_fixed(
   h1("Dynamic Sidebars"),
   tags$head(tags$title("bslib | Tests | Dynamic Sidebars")),
-  # Disable sidebar transitions for tests
-  tags$style(":root {--bslib-sidebar-transition-duration: 0ms};"),
   p(
     "Test dynamically added sidebars.",
     "Each new layout is a nested layout with two sidebars.",

diff --git a/inst/apps/310-bslib-sidebar-dynamic/tests/testthat/test-310-bslib-sidebar-dynamic.R b/inst/apps/310-bslib-sidebar-dynamic/tests/testthat/test-310-bslib-sidebar-dynamic.R
@@ -2,7 +2,7 @@ library(shinytest2)
 
 # Only take screenshots on mac + r-release to reduce diff noise
 expect_screenshot_mac_release <- local({
-  release <- rversions::r_release()$version
+  release <- jsonlite::fromJSON("https://api.r-hub.io/rversions/resolve/release")$version
   release <- paste0(
     strsplit(release, ".", fixed = TRUE)[[1]][1:2],
     collapse = "."
@@ -69,7 +69,12 @@ test_that("310-bslib-sidebar-dynamic: dynamically added sidebars are fully funct
     width = 1200,
     view = interactive(),
     options = list(bslib.precompiled = FALSE),
-    expect_values_screenshot_args = FALSE
+    expect_values_screenshot_args = FALSE,
+    screenshot_args = list(
+      selector = "viewport",
+      delay = 0.5,
+      options = list(captureBeyondViewport = FALSE)
+    )
   )
 
   expect_sidebar_hidden <- expect_sidebar_hidden_factory(app)