Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployments #206

Closed
wants to merge 7 commits into from
Closed

Fix deployments #206

wants to merge 7 commits into from

Conversation

cpsievert
Copy link
Contributor

@cpsievert cpsievert commented Jul 31, 2023

Combines #204 and #205 into a single branch that will also trigger deployments

Closes #200
Closes #201

TODO

  • Apps need to be made public?
    • Seems like the workflow should handle this, but I think I'm the only one who can view currently?
  • Make sure R/data-connect-urls.R gets updated (not sure if that'll automatically happen or not)

@cpsievert cpsievert requested a review from schloerke July 31, 2023 22:46
@schloerke
Copy link
Contributor

Sorry. @cpsievert Is this PR covered in #209 ?

@cpsievert
Copy link
Contributor Author

I think so? As long as deployment to shinyapps.io is working then I'm good with closing this (as well as #209)

@cpsievert cpsievert closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy to shinyapps.io is failing Deploy to Connect
2 participants