Add hyrolo search test cases #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While you have the different types of matched entries in a buffer, you should use the action key on each, e.g. by moving to each string match first and then ensure the proper record from each original file is displayed.Might be good to have more than one record with some hierarchy matched from each file type so you see if the tree-level matching works. The Koutline needs the most testing in this area.Cheers,BobOn Nov 24, 2023, at 11:25 PM, Mats Lidell ***@***.***> wrote:What
Add hyrolo search test cases.
Note
Pushing the first test case that verifies searching all file types with matches gives @loc> headers. Will add more.
You can view, comment on, or merge this pull request online at:
#408
Commit Summary
66d87cf Verify searching all file types with matches gives @loc> headers
File Changes (2 files)
M
ChangeLog
(5)
M
test/hyrolo-tests.el
(21)
Patch Links:
https://github.com/rswgnu/hyperbole/pull/408.patch
https://github.com/rswgnu/hyperbole/pull/408.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Yes. I will add more test cases around this area. Stay tuned. |
matsl
force-pushed
the
hyrolo-test-cases
branch
from
66d87cf to
d842b4a
Compare
matsl
commented
Nov 29, 2023
|
|
||
| (ert-deftest hyrolo-fgrep-and-goto-next-visible-md-heading () | ||
| "Verify move to next heading, then action-key to go to record for markdown mode." | ||
| :expected-result :failed |
There was a problem hiding this comment.
@rswgnu Tagging this as expected failed due to => The hyrolo-next-visible-heading step does not bring point to the markdown heading. Is not that what is supposed to happen?
rswgnu
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add hyrolo search test cases.
Note