Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hywiki words with delimiter tests #627

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

matsl
Copy link
Collaborator

@matsl matsl commented Dec 24, 2024

What

hywiki tests for highlighting and identification of WikiWords.

Why

WikiWords are not identifies as such in all cases. In some cases
org-links are produced and in others WikiWords are not identified
since adjacent text or symbols takes precedence. So we need to have
test cases that checks there are no regressions.

@matsl
Copy link
Collaborator Author

matsl commented Dec 24, 2024

Hi @rswgnu

I was cleaning my workspace and found this branch about identifying WikiWords when there are different adjacent characters etc. I have some slight memory of us discussing this but I don't remember the outcome of that discussion. So I rebased it on top of master and made it succeed for all cases. So it covers the current behavior. Can you take a look if the tests make sense? Any more cases that should be added?

@matsl matsl requested a review from rswgnu December 24, 2024 08:37
@rswgnu
Copy link
Owner

rswgnu commented Dec 24, 2024 via email

@matsl matsl merged commit 4f8fa6f into master Dec 24, 2024
4 checks passed
@matsl matsl deleted the add-hywiki-words-with-delimiter-tests branch December 24, 2024 22:50
@matsl
Copy link
Collaborator Author

matsl commented Dec 24, 2024

In a second set of tests, we’ll need to add testing of #this-is-a-section and (WikiWord#Section2), delimited tests. Ignore spaces for now since we are going to disallow thise in section names and convert to dashes somehow, at which point we can add those tests.

Yes. I think there is a small start on that but will try to expand on it.

@rswgnu
Copy link
Owner

rswgnu commented Dec 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants