Showing problems with handling sections. #628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsl
commented
Dec 26, 2024
| @@ -639,10 +641,11 @@ After successfully finding a page and reading it into a buffer, run | |||
| (unless buffer-file-name | |||
| (error "(hywiki-display-referent): No `wikiword' given; buffer must have an attached file")) | |||
| (setq wikiword (file-name-sans-extension (file-name-nondirectory buffer-file-name)))) | |||
| (when (string-match "#[^#]+$" wikiword) | |||
There was a problem hiding this comment.
Here wikiword is set with the section removed so the following let* will never see a section. I moved it into the let* in a pragmatic way. Can probably be improved.
matsl
commented
Dec 26, 2024
| @@ -614,8 +614,10 @@ an existing or new HyWikiWord." | |||
| (call-interactively hywiki-display-page-function) | |||
| (when (null wikiword) | |||
| (setq wikiword (hywiki-word-read-new "Find HyWiki page: "))) | |||
| (let ((referent (hywiki-get-file wikiword))) | |||
There was a problem hiding this comment.
Here hywiki-get-file drops the section info from wikiword. So I added getting the section back to it can be appended to the file name so that hpath:find can do its job.
There was a problem hiding this comment.
Why don't you just catch these with tests and then I will update to ensure the tests work right? But I see your point here. But now I'm rebasing on all my prior changes, so it is less work if you just send tests that fail. My two cents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Showing problems with handling of sections.
Why
I have started to look at writing tests for WikiWords with sections
and found that the movement to sections is broken. So before writing
tests I tried to understand what was the issue.
Two problematic parts were found and they are described in this PR. I
want to share it with you before hacking away on the tests.
Note
Observations: