Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silence obsolete when let et al warnings for emacs 31 #632

Closed

Conversation

matsl
Copy link
Collaborator

@matsl matsl commented Dec 27, 2024

What

Add EXTRA_COMP_FLAGS to control extra flags for byte and native
compilation.

Why

when-let et al are marked as obsolete from 31.1 and causes a lot of
warning messages that disturbs the output. As a quick fix introduce
the make macro so we can add settings to turn these warnings off. When
31.1 becomes closer to release we can deal with this.

Use for silencing when-let et al obsolete warnings for Emacs 31.
@matsl matsl force-pushed the silence-obsolete-when-let-et-al-warnings-for-emacs-31 branch from e09ae28 to 5f3f214 Compare December 27, 2024 19:43
@matsl matsl requested a review from rswgnu December 27, 2024 19:44
@rswgnu
Copy link
Owner

rswgnu commented Dec 27, 2024

What replaces these two calls that is not obsolete? If the others have been around for a while, we should just switch.

@matsl
Copy link
Collaborator Author

matsl commented Dec 27, 2024

What replaces these two calls that is not obsolete? If the others have been around for a while, we should just switch.

You are right. I was fooled by the deprecation warning. It says: This macro is obsolete since 31.1; use ‘when-let’ or ‘and-let*’
instead.* And when looking at when-let* it said Probably introduced at or before Emacs version 31.1. But the later is not really true. I checked with older versions of Emacs and they have when-let* and and-let* (for some versions they are in subr-x.el)

So it should be possible to replace these in a portable manner. I'll come back with another PR using that instead.

@matsl matsl closed this Dec 27, 2024
@matsl
Copy link
Collaborator Author

matsl commented Dec 27, 2024

Maybe it was amplified for me by the discussion in bug: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=+73853 where the deprecation got some criticism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants