Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests to use with-simulated-input #634

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Refactor tests to use with-simulated-input #634

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
416d25f
Refactor tests to use with-simulated-input
matsl Dec 28, 2024
2cae8a9
Refactor testcase after review
matsl Dec 29, 2024
51ebfc8
Update after review
matsl Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 18 additions & 19 deletions test/hywiki-tests.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
;; Author: Mats Lidell
;;
;; Orig-Date: 18-May-24 at 23:59:48
;; Last-Mod: 26-Dec-24 at 23:34:51 by Bob Weiner
;; Last-Mod: 28-Dec-24 at 16:58:48 by Mats Lidell
;;
;; SPDX-License-Identifier: GPL-3.0-or-later
;;
Expand Down Expand Up @@ -677,21 +677,27 @@ Note special meaning of `hywiki-allow-plurals-flag'."

(ert-deftest hywiki-tests--add-bookmark ()
"Verify `hywiki-add-bookmark'."
(let ((hywiki-directory (make-temp-file "hywiki" t)))
(let ((hywiki-directory (make-temp-file "hywiki" t))
(bookmark-alist nil)
(file (make-temp-file "hypb.txt")))
(unwind-protect
(progn
(mocklet ((bookmark-completing-read => ""))
(find-file file)
(with-simulated-input "RET"
(should-error (hywiki-add-bookmark "WikiWord")))
(mocklet ((bookmark-completing-read => "bkmark"))
(should (equal '(bookmark . "bkmark") (hywiki-add-bookmark "WikiWord")))))
(bookmark-set "bookmark")
(with-simulated-input "bookmark RET"
(hywiki-add-bookmark "WikiWord")
(should (equal '(bookmark . "bookmark") (hywiki-get-referent "WikiWord")))))
(hy-delete-file-and-buffer file)
(hy-delete-dir-and-buffer hywiki-directory))))

(ert-deftest hywiki-tests--add-command ()
"Verify `hywiki-add-command'."
(let ((hywiki-directory (make-temp-file "hywiki" t))
(wikiword "WikiWord"))
(unwind-protect
(mocklet ((hui:actype => 'hpath:find))
(with-simulated-input "hpath:find RET"
(hywiki-add-command wikiword)
(should (equal '(command . hpath:find)
(hywiki-get-referent wikiword))))
Expand Down Expand Up @@ -725,26 +731,19 @@ Note special meaning of `hywiki-allow-plurals-flag'."
"Verify `hywiki-add-info-index'."
(let ((hywiki-directory (make-temp-file "hywiki" t)))
(unwind-protect
(progn
(mocklet (((info) => t)
((Info-read-index-item-name "Info index item: ") => "index-name")
((Info-current-filename-sans-extension) => "info"))
(hywiki-add-info-index "WikiWord")
(should (equal '(info-index . "(info)index-name") (hywiki-get-referent "WikiWord"))))
;; Verify display of referent
(mocklet (((hact 'link-to-Info-index-item "(info)index-name") => t))
(hywiki-display-referent "WikiWord")))
(with-simulated-input "files RET"
(info "emacs")
(hywiki-add-info-index "WikiWord")
(should (equal '(info-index . "(emacs)files") (hywiki-get-referent "WikiWord"))))
(hy-delete-dir-and-buffer hywiki-directory))))

(ert-deftest hywiki-tests--add-info-node ()
"Verify `hywiki-add-info-node'."
(let ((hywiki-directory (make-temp-file "hywiki" t)))
(unwind-protect
(mocklet (((info) => t)
((Info-read-node-name "Info node: ") => "node-name")
((Info-current-filename-sans-extension) => "info"))
(with-simulated-input "(emacs) RET"
(hywiki-add-info-node "WikiWord")
(should (equal '(info-node . "(info)node-name") (hywiki-get-referent "WikiWord"))))
(should (equal '(info-node . "(emacs)") (hywiki-get-referent "WikiWord"))))
(hy-delete-dir-and-buffer hywiki-directory))))

(ert-deftest hywiki-tests--add-key-series ()
Expand Down
Loading