Skip to content

Prepare framework for insert and yank hywiki tests#763

Merged
matsl merged 9 commits into
masterfrom
add-hywiki-highlight-test-support
Nov 13, 2025
Merged

Prepare framework for insert and yank hywiki tests#763
matsl merged 9 commits into
masterfrom
add-hywiki-highlight-test-support

Conversation

@matsl
Copy link
Copy Markdown
Collaborator

@matsl matsl commented Jul 11, 2025

What

Prepare framework for insert and yank hywiki tests.

Why

We need to be able to perform many tests where buffer contents is
changed due to insertion, killing and yanking while verifying that the
hywiki words are highlighted properly.

@matsl matsl marked this pull request as ready for review July 13, 2025 21:42
@matsl matsl requested a review from rswgnu July 13, 2025 21:43
Comment thread test/hywiki-tests.el Outdated
@matsl matsl force-pushed the add-hywiki-highlight-test-support branch from 2f01893 to 37fdb14 Compare July 26, 2025 22:40
Comment thread test/hywiki-yki-tests.el Outdated
@matsl matsl requested a review from rswgnu July 26, 2025 23:00
@matsl matsl force-pushed the add-hywiki-highlight-test-support branch from 37fdb14 to 50414e7 Compare July 27, 2025 20:42
@matsl matsl marked this pull request as draft July 31, 2025 21:59
@matsl
Copy link
Copy Markdown
Collaborator Author

matsl commented Jul 31, 2025

Converted to draft while we are evaluating this.

@matsl matsl force-pushed the add-hywiki-highlight-test-support branch from 50414e7 to 0e70c1b Compare November 11, 2025 16:32
@matsl
Copy link
Copy Markdown
Collaborator Author

matsl commented Nov 11, 2025

@rswgnu For what it is worth I rebased this PR today to see what test still were failing and to my delight all highlight tests are now passing.

@rswgnu
Copy link
Copy Markdown
Owner

rswgnu commented Nov 12, 2025

@matsl add this to the MANIFEST and to the ChangeLog and then we can merge it if all the tests are passing.

@matsl matsl force-pushed the add-hywiki-highlight-test-support branch from 0e70c1b to afb968f Compare November 12, 2025 15:10
@matsl matsl marked this pull request as ready for review November 12, 2025 15:24
@matsl
Copy link
Copy Markdown
Collaborator Author

matsl commented Nov 12, 2025

@rswgnu OK. It is updated and I converted it from draft into a regular PR. We had it as a draft since it is overlapping the hywiki-tests--edit test in hywiki-tests.el. Remember we had two different frameworks for how to perform these tests and this was my proposal. I thinks it is a good idea to merge it in. It does more good than harm to have it in and we can over time see how we should develop the testing.

@rswgnu
Copy link
Copy Markdown
Owner

rswgnu commented Nov 13, 2025

Ok

@matsl matsl merged commit a7f6199 into master Nov 13, 2025
4 checks passed
@matsl matsl deleted the add-hywiki-highlight-test-support branch November 13, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants