First stab at publishing with org ids #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test case works for regular WikiWords and with sections. Needs further work with tests and possibly refactoring.
matsl
force-pushed
the
export_hywiki_with_use_of_org_ids
branch
from
fb19f7c to
6de7c5b
Compare
Test is constructed to work by verifying what is produced. Comments point to what is the expected result when the code is fixed. There is one test that causes a crash. It is for simplicity commented out.
rswgnu
changed the title
|
Please add a description of anything not yet working with the HyWiki html export command. |
rswgnu
requested changes
Nov 2, 2025
hywiki.el
Outdated
| (hywiki-word-read))) | ||
|
|
||
| (defun hywiki--org-link-html-format (path-stem suffix desc info) | ||
| "Format a HTML link using org ids." |
There was a problem hiding this comment.
Use 'an html' not 'a HTML'. Only function argument names should be all caps in doc strings.
rswgnu
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Test case works for regular WikiWords and with sections.
Needs further work with tests and possibly refactoring.
Sharing for feedback.
I have today experimented with your hywiki folder. All files except one can be
exported with out any runtime error. The BB.org files causes an error which I
will look into.
I have not doubled checked all links but to my surprise I found rather few
proper links in the material. So not sure how I can use it to create more
types of tests from it. (Except for the BB.org file that is.)
Further updates.
I was able to find what input causes the error and also found two cases where
the generated output does not match the expected output. This is for plain
WikiWord generation, i.e. no sections involved.
It is documented in a test case in the mentioned PR.
Next step is to figure out what is happening and fix it.