Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RealSenseのcamera_namespace対応 #157

Merged
merged 1 commit into from
Jun 24, 2024
Merged

RealSenseのcamera_namespace対応 #157

merged 1 commit into from
Jun 24, 2024

Conversation

Kuwamai
Copy link
Contributor

@Kuwamai Kuwamai commented Jun 21, 2024

What does this implement/fix?

RealSenseのトピック名にcamera_namespaceが追加され、カメラサンプルが動作しない状態になっていたため修正しました。
既存のカメラサンプルには変更を加えず、camera_namespaceを空欄にすることで対応してます。

Does this close any currently open issues?

しません。

How has this been tested?

カメラサンプルが動作することを確認しました。

ros2 launch sciurus17_examples demo.launch.py
ros2 launch sciurus17_examples head_camera_tracking.launch.py

Any other comments?

ないです。

Checklists

@Kuwamai Kuwamai added the Type: Bug Bug or Bug fixes label Jun 21, 2024
@Kuwamai Kuwamai requested a review from ShotaAk June 21, 2024 09:44
@Kuwamai Kuwamai self-assigned this Jun 21, 2024
@ShotaAk
Copy link
Collaborator

ShotaAk commented Jun 24, 2024

Related Issue: IntelRealSense/realsense-ros#2866

Copy link
Collaborator

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShotaAk ShotaAk merged commit 87d0075 into ros2 Jun 24, 2024
@ShotaAk ShotaAk deleted the fix_realsense_ns branch June 24, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants