cortex-m-source-masking: use global critical section when resource is shared with exception handler #1094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1088.
This implements a simple but somewhat heavy-handed fix for the issue described in #1088:
If at least one of the tasks accessing a shared resource is an exception handler, then the access is protected by a global critical section, regardless of the priorities of tasks involved.
Unfortunately, this blocks all tasks, even those that have higher priority and do not access the shared resource. In the future it might be worthwhile to look into some way to mask the exception handlers (maybe by dynamically lowering exception priorities).
TODO:
Update documentation to note the new behavior.Add note to changelog.PS: I know that the CI is failing, but as far as I can tell this is caused by automatic updates to the Rust toolchain used in the CI, not by my changes.