Enhancements to load time filtering and favorites #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since quickfilter doesn't work when only showing favorites, it made sense to have an easy way to do that. I shrunk the current breed filter buttons slightly to fit an extra button at the end. It uses the "Star" favorites icon and reads your current "favorites filter" state when loaded.
Since filtering state is saved between reloads, it makes sense to set the filters status according to the current filters state. This fix reads the state of the filter at load time and sets the buttons accordingly. If all pet types are currently not filtered (i.e. all pet types are showing) we update the ui to not show any filter.
Since many times favorites are used to store pets the user would like to level, I've enhanced the new "Favorites" button to swap your sort order when you right click it (as well as swap your favorites). This allows you to quickly see your low level favorite pets or high level favorite pets quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features added: