LPD-31852 Site Navigation Menu REST API - Name & Link #562
Conversation
postNavigationMenu does not contain navigationMenuItems since they are added calling local service instead of through the POST call.
…ring tearDownClass
… so it uses _equals helper method instead of Objects.deepEquals to compare arrays of Navigation Menu Items. This is needed because Navigation Menu Items returned contain fields that are not present in the post request.
…Menu Items including custom fields
… or without Navigation menu Items
…ion Menu Item is added without Navigation Menu Items, since these are later added via service calls
… is generated including Navigation Menu Items
… and verify they are returned when getting a Navigation Menus page
…L since a StackOverflowError is happening in the generated testing code. Without this commit the following tests fail: - NavigationMenuResourceTest. testGraphQLDeleteNavigationMenu - NavigationMenuResourceTest. testGraphQLGetNavigationMenu - NavigationMenuResourceTest. testGraphQLGetNavigationMenuNotFound - NavigationMenuResourceTest. testGraphQLGetSiteNavigationMenusPage - NavigationMenuResourceTest. testGraphQLPostSiteNavigationMenu testGraphQLDeleteNavigationMenu java.lang.StackOverflowError at java.lang.Class.getDeclaredFields(Class.java:1915) at com.liferay.petra.reflect.ReflectionUtil.getDeclaredFields(ReflectionUtil.java:33) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getDeclaredFields(BaseNavigationMenuResourceTestCase.java:1371) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1211) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) testGraphQLGetNavigationMenu java.lang.StackOverflowError at java.lang.reflect.Field.getAnnotation(Field.java:1120) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1199) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) testGraphQLGetNavigationMenuNotFound java.lang.StackOverflowError at java.lang.reflect.Field.getAnnotation(Field.java:1120) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1199) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) testGraphQLGetSiteNavigationMenusPage java.lang.StackOverflowError at java.lang.RuntimeException.<init>(RuntimeException.java:96) at com.liferay.petra.function.transform.TransformUtil.transform(TransformUtil.java:64) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getDeclaredFields(BaseNavigationMenuResourceTestCase.java:1370) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1211) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) testGraphQLPostSiteNavigationMenu java.lang.StackOverflowError at java.lang.RuntimeException.<init>(RuntimeException.java:96) at com.liferay.petra.function.transform.TransformUtil.transform(TransformUtil.java:64) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getDeclaredFields(BaseNavigationMenuResourceTestCase.java:1370) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1211) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210)
… ensure backward compatibility
…e the third element, we don't need to iterate for all the stack traces
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
PR_Conflicts_Alert[bot]
29 similar comments
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
master