LPD-28845 + LPD-31166 Pages API with REST BUilder Fix #563
Conversation
…L since a StackOverflowError is happening in the generated testing code. Without this commit the following tests fail: - NavigationMenuResourceTest. testGraphQLDeleteNavigationMenu - NavigationMenuResourceTest. testGraphQLGetNavigationMenu - NavigationMenuResourceTest. testGraphQLGetNavigationMenuNotFound - NavigationMenuResourceTest. testGraphQLGetSiteNavigationMenusPage - NavigationMenuResourceTest. testGraphQLPostSiteNavigationMenu testGraphQLDeleteNavigationMenu java.lang.StackOverflowError at java.lang.Class.getDeclaredFields(Class.java:1915) at com.liferay.petra.reflect.ReflectionUtil.getDeclaredFields(ReflectionUtil.java:33) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getDeclaredFields(BaseNavigationMenuResourceTestCase.java:1371) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1211) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) testGraphQLGetNavigationMenu java.lang.StackOverflowError at java.lang.reflect.Field.getAnnotation(Field.java:1120) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1199) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) testGraphQLGetNavigationMenuNotFound java.lang.StackOverflowError at java.lang.reflect.Field.getAnnotation(Field.java:1120) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1199) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) testGraphQLGetSiteNavigationMenusPage java.lang.StackOverflowError at java.lang.RuntimeException.<init>(RuntimeException.java:96) at com.liferay.petra.function.transform.TransformUtil.transform(TransformUtil.java:64) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getDeclaredFields(BaseNavigationMenuResourceTestCase.java:1370) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1211) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) testGraphQLPostSiteNavigationMenu java.lang.StackOverflowError at java.lang.RuntimeException.<init>(RuntimeException.java:96) at com.liferay.petra.function.transform.TransformUtil.transform(TransformUtil.java:64) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getDeclaredFields(BaseNavigationMenuResourceTestCase.java:1370) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1211) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210)
…g GraphQL since a StackOverflowError is happening in the generated testing code." This reverts commit 7dd7dcd293c6b3eab67cb1196fdd7383b8c33f04.
… within the child schemas
…rough REST builder
…lementation of the serializable interface
…ss in REST Builder
This will simplify the process to update the expected files. On a successful test run the files should be the same and git should not report any changes.
…es of the abstract class
…ad of an instance of the parent
…." until LPD-29652 is fixed
…T succeeds verify if this can be avoided, since we lose some context on what the fiels refer to.
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
PR_Conflicts_Alert[bot]
17 similar comments
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
master