WIP2 LPD-28845 + LPD-31166 Pages API with REST Builder Fix #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L since a StackOverflowError is happening in the generated testing code. Without this commit the following tests fail: - NavigationMenuResourceTest. testGraphQLDeleteNavigationMenu - NavigationMenuResourceTest. testGraphQLGetNavigationMenu - NavigationMenuResourceTest. testGraphQLGetNavigationMenuNotFound - NavigationMenuResourceTest. testGraphQLGetSiteNavigationMenusPage - NavigationMenuResourceTest. testGraphQLPostSiteNavigationMenu testGraphQLDeleteNavigationMenu java.lang.StackOverflowError at java.lang.Class.getDeclaredFields(Class.java:1915) at com.liferay.petra.reflect.ReflectionUtil.getDeclaredFields(ReflectionUtil.java:33) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getDeclaredFields(BaseNavigationMenuResourceTestCase.java:1371) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1211) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) testGraphQLGetNavigationMenu java.lang.StackOverflowError at java.lang.reflect.Field.getAnnotation(Field.java:1120) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1199) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) testGraphQLGetNavigationMenuNotFound java.lang.StackOverflowError at java.lang.reflect.Field.getAnnotation(Field.java:1120) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1199) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) testGraphQLGetSiteNavigationMenusPage java.lang.StackOverflowError at java.lang.RuntimeException.<init>(RuntimeException.java:96) at com.liferay.petra.function.transform.TransformUtil.transform(TransformUtil.java:64) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getDeclaredFields(BaseNavigationMenuResourceTestCase.java:1370) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1211) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) testGraphQLPostSiteNavigationMenu java.lang.StackOverflowError at java.lang.RuntimeException.<init>(RuntimeException.java:96) at com.liferay.petra.function.transform.TransformUtil.transform(TransformUtil.java:64) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getDeclaredFields(BaseNavigationMenuResourceTestCase.java:1370) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1211) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210) at com.liferay.headless.delivery.resource.v1_0.test.BaseNavigationMenuResourceTestCase.getGraphQLFields(BaseNavigationMenuResourceTestCase.java:1210)
…g GraphQL since a StackOverflowError is happening in the generated testing code." This reverts commit 7dd7dcd293c6b3eab67cb1196fdd7383b8c33f04.
… within the child schemas
…rough REST builder
…lementation of the serializable interface
…ss in REST Builder
This will simplify the process to update the expected files. On a successful test run the files should be the same and git should not report any changes.
…es of the abstract class
…ad of an instance of the parent
Otherwise, the following error occurs when executing rest builder:
Exception in thread "main" java.lang.RuntimeException: Error generating REST API
Java method "com.liferay.portal.tools.rest.builder.internal.freemarker.tool.FreeMarkerTool.getDTOProperties(com.liferay.portal.tools.rest.builder.internal.yaml.config.ConfigYAML, com.liferay
.portal.tools.rest.builder.internal.yaml.openapi.OpenAPIYAML, com.liferay.portal.tools.rest.builder.internal.yaml.openapi.Schema, Map)" threw an exception when invoked on com.liferay.portal.
tools.rest.builder.internal.freemarker.tool.FreeMarkerTool object "com.liferay.portal.tools.rest.builder.internal.freemarker.tool.FreeMarkerTool@1a01ae52"; see cause exception in the Java stack trace.
----
FTL stack trace ("~" means nesting-related):
- Failed at: properties = freeMarkerTool.getDTOPro... [in template "com/liferay/portal/tools/rest/builder/dependencies/dto.ftl" at line 133, column 17]
----
at com.liferay.portal.tools.rest.builder.RESTBuilder.main(RESTBuilder.java:119)
Caused by: freemarker.core._TemplateModelException: Java method "com.liferay.portal.tools.rest.builder.internal.freemarker.tool.FreeMarkerTool.getDTOProperties(com.liferay.portal.tools.rest.builder.internal.yaml.config.ConfigYAML, com.liferay.portal.tools.rest.builder.internal.yaml.openapi.OpenAPIYAML, com.liferay.portal.tools.rest.builder.internal.yaml.openapi.Schema, Map)" threw an exception when invoked on com.liferay.portal.tools.rest.builder.internal.freemarker.tool.FreeMarkerTool object "com.liferay.portal.tools.rest.builder.internal.freemarker.tool.FreeMarkerTool@1a01ae52"; see cause exception in the Java stack trace.
----
FTL stack trace ("~" means nesting-related):
- Failed at: properties = freeMarkerTool.getDTOPro... [in template "com/liferay/portal/tools/rest/builder/dependencies/dto.ftl" at line 133, column 17]
----
at freemarker.ext.beans._MethodUtil.newInvocationTemplateModelException(_MethodUtil.java:292)
at freemarker.ext.beans._MethodUtil.newInvocationTemplateModelException(_MethodUtil.java:264)
at freemarker.ext.beans.OverloadedMethodsModel.exec(OverloadedMethodsModel.java:66)
at freemarker.core.MethodCall._eval(MethodCall.java:62)
at freemarker.core.Expression.eval(Expression.java:101)
at freemarker.core.Assignment.accept(Assignment.java:134)
at freemarker.core.Environment.visit(Environment.java:335)
at freemarker.core.Environment.visit(Environment.java:341)
at freemarker.core.Environment.visit(Environment.java:341)
at freemarker.core.Environment.process(Environment.java:314)
at freemarker.template.Template.process(Template.java:383)
at com.liferay.portal.tools.rest.builder.internal.freemarker.FreeMarker.processTemplate(FreeMarker.java:53)
at com.liferay.portal.tools.rest.builder.internal.freemarker.util.FreeMarkerUtil.processTemplate(FreeMarkerUtil.java:24)
at com.liferay.portal.tools.rest.builder.RESTBuilder._createDTOFile(RESTBuilder.java:881)
at com.liferay.portal.tools.rest.builder.RESTBuilder.build(RESTBuilder.java:282)
at com.liferay.portal.tools.rest.builder.RESTBuilder.main(RESTBuilder.java:108)
Caused by: java.lang.NullPointerException
at com.liferay.portal.tools.rest.builder.internal.freemarker.tool.java.parser.DTOOpenAPIParser._getPropertyType(DTOOpenAPIParser.java:259)
at com.liferay.portal.tools.rest.builder.internal.freemarker.tool.java.parser.DTOOpenAPIParser.getProperties(DTOOpenAPIParser.java:80)
at com.liferay.portal.tools.rest.builder.internal.freemarker.tool.FreeMarkerTool.getDTOProperties(FreeMarkerTool.java:311)
at sun.reflect.GeneratedMethodAccessor76.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1553)
at freemarker.ext.beans.ReflectionCallableMemberDescriptor.invokeMethod(ReflectionCallableMemberDescriptor.java:56)
at freemarker.ext.beans.MemberAndArguments.invokeMethod(MemberAndArguments.java:51)
at freemarker.ext.beans.OverloadedMethodsModel.exec(OverloadedMethodsModel.java:62)
... 13 more
…ings and ContentPageTemplateSettings
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
PR_Conflicts_Alert[bot]
17 similar comments
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master