WIP LPD-42539 SitePage Batch Export Import Test prepared for taskItemDelegate #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# breaking ## What modules/apps/commerce/commerce-currency-api/bnd.bnd modules/apps/commerce/commerce-currency-api/src/main/java/com/liferay/commerce/currency/util/CommercePriceFormatter.java now className as a parameter for parse(ActionRequest actionRequest, String className, String param) and parse(String className, String price, Locale locale) ## Why this change is required to handle throwing of exceptions with correct class ----
Removed as part of: liferay@b598fdf
…tings does not overwrite existing persisted preferences for other actions, such as canonicals and custom tags
…s if there are existing rels
…e directly to feature flags the portlet is not properly loaded
getSiteSiteByExternalReferenceCodeSitePagesPage returning widget pages
…il put (with upsert) is implemented for SitePages
Jackson cannot infer the type discriminator if the class is not a direct instance of the polymorphic subclass. When we instantiate the subclass with an initializer block we are actually creating a subtype of the subclass which causes the serialization to fail. This CURL reproduces the issue: curl -X 'GET' \ 'http://localhost:8080/o/headless-admin-site/v1.0/sites/L_GUEST/site-pages' \ -H 'accept: application/json' \ -u '[email protected]:test' Returning this JSON: { ... "pageSettings" : { "type" : "SitePageDTOConverter$2", "hiddenFromNavigation" : true, "layoutTemplateId" : "1_2_columns_i", "type" : "WidgetPageSettings" }, ... }
…t was used for export
… invoking the import task endpoint
…dmin site test module
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
PR_Conflicts_Alert[bot]
3 similar comments
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master