This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 43
2402-1 #205
Open
dbakovich
wants to merge
1
commit into
rubizza-camp:master
Choose a base branch
from
dbakovich:2402-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
2402-1 #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 12, 2018
|
||
# Files act like a collection of lines | ||
File.open('example_file.txt') do |file| | ||
upcase_lines = file.map { |line| line.strip.upcase } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NestedIterators: AboutIteration#test_all_iteration_methods_work_on_any_collection_not_just_arrays contains iterators nested 2 deep. More info.
change commit name messages, current messages looks not good. |
+1 to @anatoliliotych comment |
dbakovich
commented
Jul 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anatoliliotych, @Saicheg
changed commit name messages
anatoliliotych
suggested changes
Jul 17, 2018
attr_reader :values | ||
|
||
def roll(number_of_rolls) | ||
@values = (0...number_of_rolls).map { rand(1..6) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace on Array initialization.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Номер
2402
Номер задания
1
Ссылка на видео с демо
https://www.youtube.com/watch?v=pUAe0_Okxlg
Комментарии
Впорядке