This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
[WIP]2198-2 #234
Open
[WIP]2198-2 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit messages should look like in style guide, please fix. |
anatoliliotych
suggested changes
Jul 17, 2018
2198/2/ruby_versus.rb
Outdated
| require 'russian_obscenity' | ||
| require 'terminal-table' | ||
|
|
||
| # rubocop:disable Metrics/LineLength |
There was a problem hiding this comment.
remove all these comments.
2198/2/ruby_versus.rb
Outdated
| # rubocop:enable Metrics/LineLength | ||
| # rubocop:enable Metrics/MethodLength | ||
| # rubocop:enable Style/ConditionalAssignment | ||
| # rubocop:enable Lint/UnusedBlockArgument |
There was a problem hiding this comment.
Use OOP style for solving this task.
houndci-bot
reviewed
Jul 18, 2018
2198/2/ruby_versus.rb
Outdated
|
|
||
| param_name, param_value = ARGF.argv[0].split('=') | ||
| if param_name == '--top-bad-words' | ||
| top_bad_words = param_value.to_i |
There was a problem hiding this comment.
Lint/UselessAssignment: Useless assignment to variable - top_bad_words.
|
fix commit messages. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Номер
2198
Номер задания
2
Ссылка на видео с демо
https://youtu.be/bMegf9BDQC0
Комментарии
Сделан уровень 1