This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
2223-3 #294
Open
2223-3 #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 27, 2018
2223/3/app/helpers/azure.rb
Outdated
| headers = { 'Content-Type' => 'application/json', | ||
| 'Ocp-Apim-Subscription-Key' => File.read('settings/azure_key.txt') } | ||
| connection.post do |request| | ||
| request.url PATH |
There was a problem hiding this comment.
FeatureEnvy: Azure#response refers to 'request' more than self (maybe move it to another class?). More info.
kislak
reviewed
Aug 8, 2018
| require 'json' | ||
| require 'mechanize' | ||
| require 'faraday' | ||
| require 'pry' |
There was a problem hiding this comment.
this gem is used in dev mode
you should not require 'pry' in production.
kislak
reviewed
Aug 8, 2018
| @@ -0,0 +1,47 @@ | |||
| require 'faraday' | |||
| require 'pry' | |||
kislak
reviewed
Aug 8, 2018
| end | ||
|
|
||
| def connection | ||
| headers = { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Номер
2223
Номер задания
3
Ссылка на видео с демо
https://youtu.be/r1sAs2qrgYo
Комментарии
Выполнено