Skip to content

Conversation

@Babar
Copy link

@Babar Babar commented Oct 24, 2025

revese.each_with_index has the exact same behavior as reverse.each, therefore add it to the cop too

Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.


Before submitting the PR make sure the following are checked:

  • [✅] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • [✅] Wrote good commit messages.
  • [✅] Commit message starts with [Fix #issue-number] (if the related issue exists).
  • [✅] Feature branch is up-to-date with master (if not - rebase it).
  • [✅] Squashed related commits together.
  • [✅] Added tests.
  • [✅] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • [✅] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

`revese.each_with_index` has the exact same behavior as `reverse.each`, therefore add it to the cop too
@Babar Babar force-pushed the ReverseEachWithIndex branch from d130d42 to ae874d2 Compare October 26, 2025 06:37
@Babar
Copy link
Author

Babar commented Oct 26, 2025

Found a computer which could actually run bundle exec rake. Fixed the few mistakes I had in the spec, and now everything looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant