Skip to content

Conversation

@mensfeld
Copy link
Collaborator

@mensfeld mensfeld commented Dec 11, 2025

Summary

  • Remove the unused Appraisals file - Rails integration tests now run via bin/integrations with LocalStack
  • Update README testing instructions to reflect the new integration test approach

Test plan

  • Verified integration tests still pass: ./bin/integrations rails runs 5/5 tests successfully
  • Confirmed appraisal gem is not a dependency in Gemfile or gemspec

Closes #789

Summary by CodeRabbit

  • Documentation

    • Updated integration testing instructions to use LocalStack with docker-compose workflow for running integration specs.
  • Chores

    • Removed gem version specifications from test configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

The Appraisals gem is no longer used - Rails integration tests are now
run via the new `bin/integrations` system with LocalStack.

Closes #789
@coderabbitai
Copy link

coderabbitai bot commented Dec 11, 2025

Walkthrough

Removed activejob gem dependencies from Appraisal configurations for Rails 7.2, 8.0, and 8.1. Updated integration testing documentation to replace Rails-focused appraisal commands with a LocalStack-based workflow using docker-compose and bundle exec rake.

Changes

Cohort / File(s) Change Summary
Appraisal configuration cleanup
Appraisals
Removed activejob gem (~> 7.2, ~> 8.0, ~> 8.1) specifications from test groups for rails_7_2, rails_8_0, and rails_8_1 appraise blocks
Integration testing documentation update
README.md
Replaced appraisal-based Rails spec commands and moto-sqs-server guidance with LocalStack-based integration test workflow (docker-compose up -d + bundle exec rake spec:integration)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

  • Appraisals: Straightforward removal of three gem dependency entries—verify no other configurations depend on these removed gems
  • README.md: Documentation update simplifying test instructions—ensure LocalStack setup is properly documented elsewhere or linked

Possibly related PRs

  • #810: Adds Rails 7.2/8.0 appraisals and gemfiles, while this PR removes activejob dependencies from the same Rails version configurations
  • #898: Modifies the same Appraisals configuration blocks for rails_7_2, rails_8_0, and rails_8_1
  • #803: Related cleanup effort removing appraisal/gemfile-based test configurations

Suggested labels

rails

Suggested reviewers

  • phstc

Poem

🐰 The Appraisal grows lean, dependencies shed,

LocalStack now leads where appraisals once tread,

Three Rails versions pruned with a cleanup so bright,

Testing simplified, the bundle feels light! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main changes: removing the unused Appraisals file and updating the README documentation.
Linked Issues check ✅ Passed The PR directly addresses issue #789 by removing unused Appraisals configurations and updating README, fulfilling the stated objective to clean up extra gemspecs and Appraisals.
Out of Scope Changes check ✅ Passed All changes are directly related to the linked issue: removing Appraisals configurations and updating README integration test instructions, with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cleanup-appraisals-789

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1dc396e and ffd54fa.

📒 Files selected for processing (2)
  • Appraisals (0 hunks)
  • README.md (1 hunks)
💤 Files with no reviewable changes (1)
  • Appraisals
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Integrations (3.2)
  • GitHub Check: Integrations (3.4)
  • GitHub Check: Integrations (3.3)
  • GitHub Check: Integrations (3.2)
  • GitHub Check: Integrations (3.3)
  • GitHub Check: Integrations (3.4)
🔇 Additional comments (1)
README.md (1)

66-71: Clear and concise update to integration testing workflow.

The updated instructions correctly reflect the migration from appraisal-based Rails testing to LocalStack-based integration testing. The format is consistent with the unit testing section above, and the commands are straightforward.

Minor observations:

  • The syntax docker compose up -d (without hyphen) is the modern, preferred approach. ✓
  • Instructions assume docker/docker-compose prerequisites, which is reasonable for a LocalStack setup.
  • No explicit mention of cleanup (e.g., docker compose down), but this is a reasonable trade-off for brevity and user discretion.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mensfeld mensfeld merged commit 5e024b3 into main Dec 11, 2025
17 checks passed
@mensfeld mensfeld deleted the cleanup-appraisals-789 branch December 11, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up the extra gemspecs and Appraisals

2 participants