Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,12 @@
- `Shoryuken::Errors::InvalidEventError` for invalid lifecycle event names
- `Shoryuken::Errors::InvalidDelayError` for delays exceeding SQS 15-minute maximum
- `Shoryuken::Errors::InvalidArnError` for invalid ARN format
- `Shoryuken::Errors::Shutdown` for graceful shutdown (replaces `Shoryuken::Shutdown`)
- Replaces generic Ruby exceptions (ArgumentError, RuntimeError) with specific error types
- Code rescuing `Shoryuken::Shutdown` must change to `Shoryuken::Errors::Shutdown`

- Removed: `Shoryuken::Shutdown` class
- This class was unused since the Celluloid removal in 2016
- Originally used to raise on worker threads during hard shutdown
- Current shutdown flow uses `Interrupt` and executor-level shutdown instead

- Fix: Raise ArgumentError when using delay with FIFO queues
- FIFO queues do not support per-message DelaySeconds
Expand Down
4 changes: 0 additions & 4 deletions lib/shoryuken/errors.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,5 @@ module Errors

# Raised when an ARN format is invalid
InvalidArnError = Class.new(BaseError)

# Exception raised to trigger graceful shutdown of the server
# @see https://github.com/mperham/sidekiq/blob/33f5d6b2b6c0dfaab11e5d39688cab7ebadc83ae/lib/sidekiq/cli.rb#L20
Shutdown = Class.new(Interrupt)
end
end