Conversation
The test case demonstrates 3 important node types that would ignore their children: - Assign - Assoc - IfOp The fact that MutationVisitor wouldn't traverse anything that's assigned to a variable, a hash key, or inside a ternary operator was very limiting.
kddnewton
approved these changes
Aug 12, 2024
kddnewton
left a comment
kddnewton
left a comment
Member
There was a problem hiding this comment.
I've accept this change, but note that the tree in this repository is going to be replaced soon by the one in prism, and I would suggest migrating to that.
Member
|
This is all going to change with the prism parser, so closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I tried to use
MutationVisitorin my gem, but realized that it doesn't traverse the entire AST.The most surprising thing perhaps was that anything assigned to a variable wouldn't be traversed. Looking at the documentation, this doesn't seem to be intended.