Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation #16

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

French translation #16

wants to merge 15 commits into from

Conversation

olivierlacan
Copy link
Contributor

@olivierlacan olivierlacan commented May 19, 2018

Hi there,

I've started working on the French translation. Haven't gotten far but I'm about to solicit community help so I thought a PR would be the appropriate way to gather assistance from my fellow Frenchies.

Thanks again for all your work on this project. I'm glad it's finally on ruby-lang.org.

Useful resources:

@easydatawarehousing
Copy link
Collaborator

Hi,

That is good news. The more translations the merrier. It is indeed a lot of work. The Dutch translation took me 3 days if I remember correct. I'm afraid my knowledge of French is far too limited to help out ...

@@ -0,0 +1,26 @@
---
lang: EN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR perhaps? (Samewise on the other files.)

@@ -0,0 +1,26 @@
---
lang: EN
title: Vous avez 30 minutes? Essayez Ruby!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In French, a space must come before double ponctuations like ? or !.


La beauté de Ruby se situe dans sa balance entre simplicité et puissance.

Vous pouvez saisir du code Ruby dans l'éditeur et utiliser les boutons suivants pour naviguer:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is missing before the colon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, English has ruined me.

- __Back__ → Vous permet de revenir à la leçon précédente
- __Clear__ → Remets l'éditeur à zéro

Utilise le bouton 'planête' <span aria-hidden="true" class="glyphicon glyphicon-globe"></span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should use double-quotes here? E.g.:

  • « planête »
  • ❝planête❞
  • "planête"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First one's the most correct for French "guillemets". Yet.

Utilise le bouton 'planête' <span aria-hidden="true" class="glyphicon glyphicon-globe"></span>
ci-dessus pour changer le language de TryRuby.

### Clique sur __Next__ pour commencer à apprendre.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are to use the tu (the friendly choice), this should be used everywhere instead of the vous (the formal choice).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, I'd rather default to friendlier. Québécois-style 😸

title: Le résumé #2 est arrivé
answer: \w+
class: stretcher chapmark
load: poem = "My toast has flown from my hand\nAnd my toast has gone to the moon.\nBut when I saw it on television,\nPlanting our flag on Halley's comet,\nMore still did I want to eat it.\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the poem also be translated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know if that'd work but we can.

error:
---

Jettons un oeil à ce qui s'est passé pendant ta deuxième minute:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minute: -> minute :

Jettons un oeil à ce qui s'est passé pendant ta deuxième minute:

### Erreurs
Si tu essayes d'inverser un nombre ou de faire des choses bizzares, Ruby
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

essayes -> essaies

Jettons un oeil à ce qui s'est passé pendant ta deuxième minute:

### Erreurs
Si tu essayes d'inverser un nombre ou de faire des choses bizzares, Ruby
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bizzares -> bizarres


Changeons de direction pour un instant. J'ai mis un petit bout de poésie
pour toi dans une certaine variable.
Jette un oeil. Saisi:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saisi: -> Saisis :

@@ -0,0 +1,26 @@
---
lang: EN
title: Vous avez 30 minutes? Essayez Ruby!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should prefer tu wherever we use vous in order to use the same everywhere?

@sunny
Copy link
Contributor

sunny commented May 23, 2018

Hey @olivierlacan, that is awesome \o/

I started a bunch of review comments, but perhaps you would rather I contribute as commits?

@olivierlacan
Copy link
Contributor Author

@sunny I'm down for commits too but the comments are really useful as well.

Copy link
Contributor

@sunny sunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New comments for French chapter 1

@@ -0,0 +1,12 @@
---
lang: FR
title: Maintenant entre ticket
Copy link
Contributor

@sunny sunny May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This title doesn't sound as good in french as it does in english. Perhaps Maintenant saisis ticket? Or Maintenant entre ton ticket / Maintenant donne ton ticket (a kind of play on words).

title: Le résumé #2 est arrivé
answer: \w+
class: stretcher chapmark
load: poem = "My toast has flown from my hand\nAnd my toast has gone to the moon.\nBut when I saw it on television,\nPlanting our flag on Halley's comet,\nMore still did I want to eat it.\n"
Copy link
Contributor

@sunny sunny May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest translating it.

This PR over your branch introduces this poem, translated: olivierlacan#2

@@ -0,0 +1,13 @@
---
lang: FR
title: Un d'entre eux lève la main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest L'un d'entre eux rather than Un d'entre eux, which sounds better to me.

Mais que faire si on a besoin d'un élement specifique de la liste?

### [ ]
Ruby utilise des crochets droits [ ] pour viser un élement.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In french I think we would simply say crochets for [] (and accolades for {}).

---

Eh, c'est pas grave. T'es pas obligé d'aimer ça. Laisses toi aller et
améliore mon poème. Au lieu d'une biscotte, tu peux essayer un melon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to change the poem in french, we should find two feminin or two masculine things so that the poem doesn't look weird when one word is replaced by another.

E.g. un toast and un melon, or une biscotte and une citrouille.

@sunny
Copy link
Contributor

sunny commented May 24, 2018

I also did other minor fixes as a pull-request over your branch : olivierlacan#1

error: Ça sent toujours la biscotte pour moi
---

Eh, c'est pas grave. T'es pas obligé d'aimer ça. Laisses toi aller et
Copy link
Contributor

@sunny sunny May 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have rather used Écoute, c'est pas grave. rather than Eh, c'est pas grave, here.


Eh, c'est pas grave. T'es pas obligé d'aimer ça. Laisses toi aller et
améliore mon poème. Au lieu d'une biscotte, tu peux essayer un melon
pourquoi pas. Essaie de voir ce nouveau poème:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here par exemple sounds better in French to me than pourquoi pas.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would simply have used Essaie rather than Essaie de voir.

@easydatawarehousing
Copy link
Collaborator

Hi guys, please let me know if I can do anything. I figured that since not all lesson content is translated I don't have to merge yet.

@olivierlacan
Copy link
Contributor Author

@easydatawarehousing All good. Still a WIP. :-)

@hmdne
Copy link
Collaborator

hmdne commented Feb 12, 2022

Hi! Is it by chance still an active effort? There are still a few untranslated files. I think we can take this at the current state along with olivierlacan#1 ... a partial translation is better than no translation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants