Skip to content

Conversation

rhiroe
Copy link
Contributor

@rhiroe rhiroe commented Jul 28, 2024

The record_timestamps argument has been added to insert_all and similar methods since ActiveRecord7.0.

ref: rails/rails#43003

@rhiroe rhiroe force-pushed the patch/rhiroe branch 2 times, most recently from f8c1f4c to ba481da Compare July 28, 2024 00:36
@rhiroe
Copy link
Contributor Author

rhiroe commented Jul 28, 2024

Tests are failing due to known defects. #619

@rhiroe rhiroe marked this pull request as ready for review July 28, 2024 01:00
Copy link

@rhiroe Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activerecord

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, @Little-Rubyist, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

Copy link

github-actions bot commented Aug 1, 2024

Thanks for your review, @ksss!

@rhiroe, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

@rhiroe
Copy link
Contributor Author

rhiroe commented Aug 2, 2024

I executed rebase.

@rhiroe
Copy link
Contributor Author

rhiroe commented Aug 2, 2024

/merge

Copy link

github-actions bot commented Aug 2, 2024

/merge command failed.

This PR is not approved yet by the reviewers. Please get approval from the reviewers.

See the Actions tab for detail.

@rhiroe
Copy link
Contributor Author

rhiroe commented Aug 2, 2024

😭
@ksss Sorry, please "APPROVE" again.

@rhiroe rhiroe requested a review from ksss August 2, 2024 02:11
Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE 👍

Copy link

github-actions bot commented Aug 2, 2024

Thanks for your review, @ksss!

@rhiroe, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

@rhiroe
Copy link
Contributor Author

rhiroe commented Aug 2, 2024

/merge

@github-actions github-actions bot merged commit 7062b1c into ruby:main Aug 2, 2024
4 checks passed
@rhiroe rhiroe deleted the patch/rhiroe branch August 2, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants