Skip to content

Create parser without defining %union #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2025
Merged

Create parser without defining %union #654

merged 1 commit into from
Sep 1, 2025

Conversation

ydah
Copy link
Member

@ydah ydah commented Mar 18, 2025 •
edited
Loading

Fixes: #480

If %union is not defined, Integer is used by default.

/* Value type.  */
#if ! defined YYSTYPE && ! defined YYSTYPE_IS_DECLARED
typedef int YYSTYPE;
# define YYSTYPE_IS_TRIVIAL 1
# define YYSTYPE_IS_DECLARED 1
#endif

@ydah ydah changed the title Refactor grammar rules to make the epilogue declaration optional in the parser input Grammar rules to make the epilogue declaration optional in the parser input Mar 18, 2025
@ydah ydah force-pushed the can-remove-%%-union branch from f6dab85 to f109739 Compare March 18, 2025 14:49
@yui-knk
Copy link
Collaborator

yui-knk commented Mar 20, 2025

Do we need to take care of "template/bison/_yacc.h" if union is nullable?

@ydah ydah marked this pull request as draft August 28, 2025 09:32
@ydah ydah marked this pull request as ready for review August 28, 2025 15:20
@ydah ydah force-pushed the can-remove-%%-union branch from f109739 to 9406bde Compare August 30, 2025 14:47
@ydah ydah requested a review from yui-knk August 30, 2025 14:48
@ydah
Copy link
Member Author

ydah commented Aug 30, 2025

Do we need to take care of "template/bison/_yacc.h" if union is nullable?

I tried to take care of it. How about this?

yui-knk
yui-knk reviewed Aug 31, 2025
View reviewed changes
yui-knk
yui-knk reviewed Aug 31, 2025
View reviewed changes
@ydah ydah changed the title Grammar rules to make the epilogue declaration optional in the parser input Create parser without defining %union Aug 31, 2025
@yui-knk
Copy link
Collaborator

yui-knk commented Sep 1, 2025

Could you squash the commits into one?

@ydah ydah changed the title Create parser without defining %union Create parser without defining %union Sep 1, 2025
@ydah
Create parser without defining %union
92de868 
Fixes: ruby#480

If %union is not defined, Integer is used by default.

```c
/* Value type.  */
#if ! defined YYSTYPE && ! defined YYSTYPE_IS_DECLARED
typedef int YYSTYPE;
# define YYSTYPE_IS_TRIVIAL 1
# define YYSTYPE_IS_DECLARED 1
#endif
```
@ydah ydah force-pushed the can-remove-%%-union branch from 0edaf79 to 92de868 Compare September 1, 2025 02:06
@ydah
Copy link
Member Author

ydah commented Sep 1, 2025 •
edited
Loading

Could you squash the commits into one?

I squash these commits!

@ydah ydah merged commit 57af1ee into ruby:master Sep 1, 2025
22 checks passed
@ydah ydah deleted the can-remove-%%-union branch September 1, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yui-knk yui-knk yui-knk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create parser without defining %union
2 participants
@ydah @yui-knk