make yp_constant_id_ts useful for constant pool indexing#1554
Closed
make yp_constant_id_ts useful for constant pool indexing#1554
yp_constant_id_ts useful for constant pool indexing#1554Conversation
froydnj
force-pushed
the
froydnj-stable-constant-id
branch
from
05e5c22 to
43a25da
Compare
Collaborator
|
Performance/memory impact? |
Contributor
Author
Performance is improved by ~1% on a subset of Stripe's codebase. Constant pool size isn't counted in |
kddnewton
reviewed
Sep 20, 2023
Collaborator
kddnewton
left a comment
kddnewton
left a comment
There was a problem hiding this comment.
Great work. I'll need to merge this into ruby/ruby first to ensure I don't break CI since this is a breaking change to the C API, then I'll merge this.
Merged
Collaborator
|
Merged this in #1605 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turns out to be really useful (#1537, #1533, #1449, etc.), and we can make everything smaller while doing so.