Skip to content

Support pattern argument for Enumerable#{all,any,none,one}? #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

Support pattern argument for Enumerable#{all,any,none,one}? #2368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions core/enumerable.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,11 @@
# find exactly one of each Hash entry.
#
module Enumerable[unchecked out Elem] : _Each[Elem]
%a{private}
interface _Pattern
def ===: (untyped) -> bool
end

# <!--
# rdoc-file=enum.c
# - all? -> true or false
Expand Down Expand Up @@ -234,6 +239,7 @@ module Enumerable[unchecked out Elem] : _Each[Elem]
# Related: #any?, #none? #one?.
#
def all?: () -> bool
| (_Pattern) -> bool
| () { (Elem) -> boolish } -> bool

# <!--
Expand Down Expand Up @@ -277,6 +283,7 @@ module Enumerable[unchecked out Elem] : _Each[Elem]
# Related: #all?, #none?, #one?.
#
def any?: () -> bool
| (_Pattern) -> bool
| () { (Elem) -> boolish } -> bool

# <!--
Expand Down Expand Up @@ -1167,6 +1174,7 @@ module Enumerable[unchecked out Elem] : _Each[Elem]
# Related: #one?, #all?, #any?.
#
def none?: () -> bool
| (_Pattern) -> bool
| () { (Elem) -> boolish } -> bool

# <!--
Expand Down Expand Up @@ -1210,6 +1218,7 @@ module Enumerable[unchecked out Elem] : _Each[Elem]
# Related: #none?, #all?, #any?.
#
def one?: () -> bool
| (_Pattern) -> bool
| () { (Elem) -> boolish } -> bool

# <!--
Expand Down
24 changes: 24 additions & 0 deletions test/stdlib/Enumerable_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,4 +241,28 @@ def test_first
assert_send_type '(ToInt n) -> ::Array[::String]' , TestEnumerable.new, :first, ToInt.new(42)
assert_send_type '(ToInt n) -> ::Array[::String]' , TestEmptyEnumerable.new, :first, ToInt.new(42)
end

def test_all_p
assert_send_type '() -> bool', TestEnumerable.new, :all?
assert_send_type '(Class) -> bool', TestEnumerable.new, :all?, String
assert_send_type '() { (String) -> bool } -> bool', TestEnumerable.new, :all? do |x| x == '0' end
end

def test_any_p
assert_send_type '() -> bool', TestEnumerable.new, :any?
assert_send_type '(Class) -> bool', TestEnumerable.new, :any?, String
assert_send_type '() { (String) -> bool } -> bool', TestEnumerable.new, :any? do |x| x == '0' end
end

def test_none_p
assert_send_type '() -> bool', TestEnumerable.new, :none?
assert_send_type '(Class) -> bool', TestEnumerable.new, :none?, String
assert_send_type '() { (String) -> bool } -> bool', TestEnumerable.new, :none? do |x| x == '0' end
end

def test_one_p
assert_send_type '() -> bool', TestEnumerable.new, :one?
assert_send_type '(Class) -> bool', TestEnumerable.new, :one?, String
assert_send_type '() { (String) -> bool } -> bool', TestEnumerable.new, :one? do |x| x == '0' end
end
end