Split Random::Formatter to core and stdlib
#2661
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CRuby, the methods of `Random::Formatter` are split between core and the stdlib random/formatter.
RBS will also create new stdlib random/formatter modules and separate the methods.
* core
* rand
* random_number
* stdlib
* base64
* hex
* random_bytes
* urlsafe_base64
* uuid
* alphanumeric
See also:
* https://bugs.ruby-lang.org/issues/18190
* https://bugs.ruby-lang.org/issues/20893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2660
In CRuby, the methods of
Random::Formatterare split between core and the stdlib random/formatter.I propose that RBS will also create new stdlib random/formatter modules and separate the methods.
This change is non-backward compatible.
However, since random-formatter is only used with securerandom and seems unlikely to cause significant issues,
we have not added migration code like stringio.
See also: