Add specs for reserved keywords #1187
Conversation
amomchilov
force-pushed
the
keywords-spec
branch
from
8908ead
to
2cc6546
Compare
| # Copied from Prism::Translation::Ripper | ||
| keywords = [ |
There was a problem hiding this comment.
TODO: It would be nice to have one canonical list that can be used in all these places:
spec/ruby/language/hash_spec.rbspec/ruby/language/reserved_keywords.rblib/prism/translation/ripper.rb- Ideally, it would also be nice to generate
doc/keywords.rdocfrom that list, to ensure that all keywords are documented.
Where should such a canonical list live?
There was a problem hiding this comment.
There is no way to avoid duplication there, since it's files in different repositories.
So for ruby/spec let's have it as a new file under language/fixtures.
I think a %w[] array would be nice for this BTW.
FWIW in ruby/ruby there is also defs/keywords.
|
|
||
| invalid_ivar_names = ["defined?"] | ||
|
|
||
| if invalid_ivar_names.include?(kw) |
There was a problem hiding this comment.
if outside examples like this are pretty much an anti-pattern in ruby/spec.
Same for looping around it.
Instead, the loops should be inside the it.
That also makes it easier to read, e.g. (keywords - %w[defined?]).each.
|
|
||
| # Evaluates the given Ruby source in a temporary Module, to prevent | ||
| # the surrounding context from being polluted with the new methods. | ||
| def sandboxed_eval(ruby_src) |
There was a problem hiding this comment.
This seems pretty expensive (creating a module for each keyword * spec examples).
Since in ruby/spec every file has its own separate Object instance as top-level self, I think we don't need to worry about this can just define on the self.
Add specifications for all the reserved keywords, documenting which of them can be used as: