Implement Write Barrier #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StringScanner holds the string being scanned, and a regex for methods like `match?`. Triggering the write barrier for those allows us to mark this as WB protected.
composerinteralia
force-pushed
the
implement-wb
branch
from
4487932 to
4cd884f
Compare
|
Do we also need to change Line 63 in d4d9b10 |
|
|
|
OK. Let's merge this. |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jun 6, 2025
(ruby/strscan#156) StringScanner holds the string being scanned, and a regex for methods like `match?`. Triggering the write barrier for those allows us to mark this as WB protected. ruby/strscan@32fec70407
sms021019
pushed a commit
to sms021019/ruby
that referenced
this pull request
Jun 17, 2025
(ruby/strscan#156) StringScanner holds the string being scanned, and a regex for methods like `match?`. Triggering the write barrier for those allows us to mark this as WB protected. ruby/strscan@32fec70407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringScanner holds the string being scanned, and a regex for methods
like
match?. Triggering the write barrier for those allows us to markthis as WB protected.