Make deep_merge a soft-requirement
#367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal here is to remove deep_merge and rely entirely on ActiveSupport's `Hash#deep_merge` implementation. This does mean that if you want to keep the existing behavior, or rely on DeepMerge's specific options, you need to add the following to your Gemfile: ```ruby gem 'deep_merge', '~> 1.2', '>= 1.2.1' ```
zzak
force-pushed
the
soft-require-deep_merge
branch
from
60fcabd to
85d692e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to remove deep_merge and rely entirely on ActiveSupport's
Hash#deep_mergeimplementation.This does mean that if you want to keep the existing behavior, or rely on DeepMerge's specific options, you need to add the following to your Gemfile:
@pkuczynski Opening this as a proof-of-concept, would you be willing to take on this type of change?
I decided not to touch the config methods, even though they are no-op when
deep_mergegem isn't included. Wanted to get feedback first, and I figure the warning is enough.