Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[##6174] added metrics for logged contacts #6198

Merged
merged 3 commits into from
Jan 30, 2025
Merged

[##6174] added metrics for logged contacts #6198

merged 3 commits into from
Jan 30, 2025

Conversation

Raushan998
Copy link

What github issue is this PR for, if any?

Resolves #6174

What changed, and why?

  • Changed inside health controller for selecting all case_contact having distinct creator_id.
  • Chaged inside metrics.js file for showing the logged volunteer on graph.
  • Changed inside health_spec.rb file for unit test.

How is this tested? (please write tests!) 💖💪

  • Written the unit test for changes inside the controller.
  • Tested on local machine for UI interface(attaching screenshot).

Screenshots please :)

Screenshot 2025-01-26 at 10 46 04 PM

Feelings gif

Monkey Enjoying GIF

@github-actions github-actions bot added javascript for use by Github Labeler to mark pull requests that update Javascript code ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Jan 26, 2025
compwron
compwron approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@compwron compwron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@compwron compwron merged commit ae0af55 into rubyforgood:main Jan 30, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compwron compwron compwron approved these changes

@schoork schoork Awaiting requested review from schoork schoork is a code owner

@FireLemons FireLemons Awaiting requested review from FireLemons FireLemons is a code owner

@elasticspoon elasticspoon Awaiting requested review from elasticspoon elasticspoon is a code owner

Assignees
No one assigned
Labels
javascript for use by Github Labeler to mark pull requests that update Javascript code ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve MAU Reporting
2 participants
@Raushan998 @compwron