-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 6187 admin new case contacts #6215
Open
alex-yi37
wants to merge
12
commits into
rubyforgood:main
Choose a base branch
from
alex-yi37:issue-6187-admin-new-case-contacts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+110
−26
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c8aeb63
initial implementation
alex-yi37 6f6e544
Merge branch 'main' into issue-6187-admin-new-case-contacts
alex-yi37 ba3f142
adds select all option that is initially checked when editing casa case
alex-yi37 cd1ea60
linting
alex-yi37 14c7aa3
remove comments
alex-yi37 13ff0d1
clean up unused code
alex-yi37 8a28aa7
fix typo in select all option text
alex-yi37 f44883f
refactor multi-select stimulus controller so it matches existing beha…
alex-yi37 f1835bd
Merge branch 'main' into issue-6187-admin-new-case-contacts
alex-yi37 ca99d15
casa_cases edit system spec passing with additional tests
alex-yi37 c9d2042
adds system spec tests for casa case creation flow
alex-yi37 a6fab58
lint spec files
alex-yi37 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,13 @@ | ||
# frozen_string_literal: true | ||
|
||
class Form::MultipleSelectComponent < ViewComponent::Base | ||
def initialize(form:, name:, options:, selected_items:, render_option_subtext: false, placeholder_term: nil) | ||
def initialize(form:, name:, options:, selected_items:, render_option_subtext: false, placeholder_term: nil, show_all_option: false) | ||
@form = form | ||
@name = name | ||
@options = options.to_json | ||
@selected_items = selected_items | ||
@render_option_subtext = render_option_subtext | ||
@placeholder_term = placeholder_term | ||
@show_all_option = show_all_option | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
' '
(space character) here seems to be treated the same as''
(empty string) when form data gets parsed in the back end. Not sure how empty string values are getting stripped when associating contact type ids with a case, but seems to work as expected since I can create casa cases locally.