Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using DRY approach to create methods #6236

Closed
wants to merge 1 commit into from

Conversation

kiku1705
Copy link

What github issue is this PR for, if any?

Using DRY to refactor the code for file - https://github.com/rubyforgood/casa/blob/main/app/models/api_credential.rb

What changed, and why?

dynamically creating methods to remove similar code definition

How is this tested? (please write tests!) 💖💪

Note: if you see a flake in your test build in github actions, please post in slack #casa "Flaky test: " :) 💪
Note: We love capybara tests! If you are writing both haml/js and ruby, please try to test your work with tests at every level including system tests like https://github.com/rubyforgood/casa/tree/main/spec/system

Screenshots please :)

Run your local server and take a screenshot of your work! Try to include the URL of the page as well as the contents of the page.

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:

![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Feb 22, 2025
@kiku1705 kiku1705 marked this pull request as ready for review February 22, 2025 16:27
@kiku1705
Copy link
Author

@7riumph I just added some code to remove duplicity from api_credentials.rb, can you look into it ?

@7riumph
Copy link
Collaborator

7riumph commented Feb 22, 2025

Hi @kiku1705, great energy, I appreciate the attempted contribution!

But we cannot accept this pull request. As there is an order of priorities.

In the future, please communicate your continued interest and preferred tasks in slack so I can assign tasks accordingly.

@7riumph 7riumph closed this Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants