Our process

The details of our project management process will be irrelevant for pull request creation. Feel free to skip this article.

After an issue is taken following the procedure in CONTRIBUTING.md, and a pull request is made, project leads will start looking at the pull request.

In general, the project leads check on open PRs several times a week. PRs with a green build will get either an approval or a maintainer request-for-changes within a day or two.

See a list of project leads here

Once the PR is merged, the github issue will auto-move itself from the “in progress” column to the “in QA” column on the project board

Then every friday afternoon we check that everything works and deploy, and move everything in “merged to QA” to “Done”. If something is broken or could be better we record it and make new tickets.

Please do check in on slack if something feels slow or stuck! Slack is the fastest way to get quick feedback. Usually faster than github comments.

If a maintainer merges a PR but there are still comments for cleanup for the PR, the maintainer should make sure that a new github issue is created for cleanup and assigned to the PR creator (the PR creator can do this if that's easier... but the maintainer is responsible for making sure it happens) If the PR creator doesn't have time/interest in doing the cleanup, put the cleanup issue back into the general todo queue The maintainer could also just wait to merge until the cleanup is done, but sometimes that isn't the best choice.