Include inactive donation sites in csv export when corresponding filter is selected #5333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er is selected and add test
dorner
requested changes
Sep 12, 2025
| wait_for_download | ||
| @csv_content = File.read(download) | ||
|
|
||
| expect(@csv_content).to have_content(active_donation_site.name) |
There was a problem hiding this comment.
I'd prefer hardcoding these names for my own peace of mind. :)
| expect(page.find(:xpath, "//table/tbody/tr[3]/td[1]")).to have_content(@third.name) | ||
| end | ||
|
|
||
| context "and exports a csv with include inactive donation sites selected" do |
There was a problem hiding this comment.
Contexts usually start with when, not and, and describe a condition, not an action.
|
@dorner thank you for your feedback. I updated my test in order to implement the suggested changes. Please let me know if this is now as it should be. |
dorner
approved these changes
Sep 19, 2025
|
Passes technical review. Over to @awwaiid for functional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5330
Description
I updated the csv export to match the view as described in the linked issue.
Type of change
How Has This Been Tested?
The
donation_sites_requests_spec.rbalready contained a test that checks if the csv includes active as well as inactive donation sites if thedonation_sites_pathis called with the required arguments:The csv export did not match the filtered view because
include_inactive_donation_siteswas not passed in as argument. Thus this was not captured by the request tests.Thus I used a system test to test the updated behavior as I could not think of another way to capture the corrected functionality.
Screenshots