#5358: Refactor donations controller to use a view object #5388
+161
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awwaiid
reviewed
Sep 21, 2025
app/models/view/donations.rb
Outdated
| @@ -0,0 +1,119 @@ | |||
| module Types | |||
There was a problem hiding this comment.
Looks like we didn't use Dry.Types
awwaiid
reviewed
Sep 21, 2025
| @paginated_donations_quantity = @paginated_donations.collect(&:total_quantity).sum | ||
| @total_value_all_donations = total_value(@donations) | ||
| @paginated_in_kind_value = total_value(@paginated_donations) | ||
| @total_money_raised = total_money_raised(@donations) |
There was a problem hiding this comment.
Looks like several of these helpers should also be removed from this controller now that they live in the view
awwaiid
requested changes
Sep 21, 2025
|
@awwaiid fixed! |
awwaiid
approved these changes
Sep 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5358
Description
This refactors the DonationsController index methods to use a single view object instead of 20 instance variables. The hope is that we can replicate this approach with further controllers.