Skip to content

Conversation

hagiya0121
Copy link
Contributor

Resolves #5004

Description

In itemized reports, inactive items previously displayed "Unknown" for Total On Hand.
Since items can only be deactivated when their inventory is already 0, the correct value should be 0 instead of "Unknown".
This update removes the "Unknown" fallback in the views and ensures that DistributionItemizedBreakdownService uses a hash with a default value of 0, so inactive items now return 0 instead of nil.
A test has also been added to confirm that inactive items correctly display 0 in reports.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Screenshots

image image

Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes technical review - over to @awwaiid for functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Total on Hand is Unknown for inactive Items on Itemized Reports -- should be 0.
2 participants