5004 Show 0 instead of “Unknown” for inactive items in itemized reports #5400
+14
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5004
Description
In itemized reports, inactive items previously displayed
"Unknown"
for Total On Hand.Since items can only be deactivated when their inventory is already 0, the correct value should be
0
instead of"Unknown"
.This update removes the
"Unknown"
fallback in the views and ensures thatDistributionItemizedBreakdownService
uses a hash with a default value of0
, so inactive items now return0
instead ofnil
.A test has also been added to confirm that inactive items correctly display
0
in reports.Type of change
How Has This Been Tested?
DistributionItemizedBreakdownService
to ensure inactive items'current_onhand
is 0.Screenshots